Add benchmarking #508
Merged
Add benchmarking #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Shane32 , you rock it! That's another great PR. Thanks for your support in this project. |
|
Hi @Shane32 seems like this PR broke the CI scripts. Can you have a look? Run dotnet restore
dotnet restore
shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
env:
GH_PKG_SEC: ***
DOTNET_ROOT: C:\Program Files\dotnet
Determining projects to restore...
Error: C:\Program Files\dotnet\sdk\7.0.[4](https://github.com/codebude/QRCoder/actions/runs/8884442673/job/24413893321#step:4:4)08\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(160,[5](https://github.com/codebude/QRCoder/actions/runs/8884442673/job/24413893321#step:4:5)): error NETSDK1045: The current .NET SDK does not support targeting .NET 8.0. Either target .NET [7](https://github.com/codebude/QRCoder/actions/runs/8884442673/job/24413893321#step:4:8).0 or lower, or use a version of the .NET SDK that supports .NET [8](https://github.com/codebude/QRCoder/actions/runs/8884442673/job/24413893321#step:4:9).0. Download the .NET SDK from https://aka.ms/dotnet/download [D:\a\QRCoder\QRCoder\QRCoderBenchmarks\QRCoderBenchmarks.csproj]
Error: Process completed with exit code 1. |
Merged
|
No problem. My mistake; I added the .NET 8 SDK twice instead of three times to those scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a benchmarking project to the solution so that performance gains during optimizations may be analyzed.
What existing problem does the pull request solve?
It is difficult to quantify the gains from applying performance optimizations without benchmarks.
Sample Output
Legend
Observations
Creating the QR code uses a lot of RAM, which triggers garbage collections more frequently. Minimizing the number of garbage collections through a more efficient QR code algorithm can significantly enhance the stability and performance of an ASP.NET Core application. By optimizing the QR code generation process, the application can manage memory better, reduce latency, and handle higher user loads with greater reliability, ultimately improving user experience and application scalability.
Similar benefits would be realized for other targets, such as blazor/webassembly.
Notes
This project targets .NET 8 so that any performance benefits are measured for a developer targeting the latest version of .NET. The compilation targets for the main project have not changed; however, the .NET 8 SDK was added to the CI workflows so that building the solution does not cause a build error.